Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd should not produce grpc.ErrClientConnTimeout errors #8504

Closed
dfawley opened this issue Sep 5, 2017 · 2 comments
Closed

etcd should not produce grpc.ErrClientConnTimeout errors #8504

dfawley opened this issue Sep 5, 2017 · 2 comments

Comments

@dfawley
Copy link

dfawley commented Sep 5, 2017

https://github.com/grpc/grpc-go/blob/4bbe223b12805ab25acbb9d2cadfab2ec9d04bb6/clientconn.go#L46-L49

gRPC has not used this error in a year. I would like to remove it, since it is dead within our project.
However, it seems etcd is generating and returning this error. Please find a more appropriate error to return; we will be removing it soon. (Note: the original PR that deprecated it said it would be removed in 2017Q1.) Thanks!
gyuho added a commit to gyuho/etcd that referenced this issue Sep 5, 2017
@gyuho
clientv3: deprecate grpc.ErrClientConnTimeout errors
312c68a 
Replace with context.DeadlineExceeded.
Address etcd-io#8504.

Signed-off-by: Gyu-Ho Lee <[email protected]>
@gyuho gyuho mentioned this issue Sep 5, 2017
Merged
@gyuho
Copy link
Contributor

gyuho commented Sep 5, 2017

@dfawley Thanks for heads-up! We've just deprecated grpc.ErrClientConnTimeout in #8505.

@gyuho gyuho closed this as completed Sep 5, 2017
@dfawley
Copy link
Author

dfawley commented Sep 6, 2017

Thanks for the super quick turnaround! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gyuho @dfawley