Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth enabled/disabled state can be lost after node reboot #7165

Closed
mitake opened this issue Jan 15, 2017 · 4 comments · Fixed by #7260
Closed

auth enabled/disabled state can be lost after node reboot #7165

mitake opened this issue Jan 15, 2017 · 4 comments · Fixed by #7260
Assignees
@mitake
Milestone
v3.2.0

Comments

@mitake
Copy link
Contributor

mitake commented Jan 15, 2017

After node reboot, sometimes the state of auth enabled/disabled can be lost. Reported by @ekle #7012 (comment)
@mitake mitake self-assigned this Jan 15, 2017
@heyitsanthony heyitsanthony added this to the v3.2.0 milestone Jan 17, 2017
@ekle
Copy link

ekle commented Jan 27, 2017

i hope a fix gets also in v3.1.1. this problem is really annoying.

@mitake
Copy link
Contributor Author

mitake commented Jan 27, 2017

@ekle sorry I was busy with other work this week. I'll be able to resume this issue from next week.

BTW, this problem happens rarely on my environment. Do you have good procedures for reproducing it?

@ekle
Copy link

ekle commented Jan 27, 2017 •
edited
Loading

here i have a 50/50 chance of getting it. but i don't know what triggers it. i have a 3 node cluster behind a aws-lb which does ssl-offloading. but it looks like it is only happening after all nodes restarted.

@mitake
Copy link
Contributor Author

mitake commented Jan 31, 2017

The problem was caused by snapshotting, small (e.g., 10) --snapshot-count option can reproduce the problem easily. It seems that current auth store cannot be recovered after node shutdown correctly. I'll work on it from tomorrow (hope it won't take a long time because the root cause is already known).

mitake added a commit to mitake/etcd that referenced this issue Feb 1, 2017
@mitake
auth: correct initialization in NewAuthStore()
c5d1832 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix etcd-io#7165
@mitake mitake mentioned this issue Feb 1, 2017
Merged
mitake added a commit to mitake/etcd that referenced this issue Feb 2, 2017
@mitake
auth: correct initialization in NewAuthStore()
5de7ad9 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix etcd-io#7165
mitake added a commit to mitake/etcd that referenced this issue Feb 6, 2017
@mitake
auth: correct initialization in NewAuthStore()
1fd2491 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix etcd-io#7165
mitake added a commit to mitake/etcd that referenced this issue Feb 6, 2017
@mitake
auth: correct initialization in NewAuthStore()
25b8f3e 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix etcd-io#7165
mitake added a commit to mitake/etcd that referenced this issue Feb 6, 2017
@mitake
auth: correct initialization in NewAuthStore()
9976d86 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix etcd-io#7165
gyuho pushed a commit that referenced this issue Feb 14, 2017
@mitake
auth: correct initialization in NewAuthStore()
4a5e7b2 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix #7165

Conflicts:
	auth/store.go
gyuho pushed a commit that referenced this issue Feb 14, 2017
@mitake @gyuho
auth: correct initialization in NewAuthStore()
9e81b00 
Because of my own silly mistake, current NewAuthStore() doesn't
initialize authStore in a correct manner. For example, after recovery
from snapshot, it cannot revive the flag of enabled/disabled. This
commit fixes the problem.

Fix #7165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitake mitake

Labels
None yet
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

auth: correct initialization in NewAuthStore() mitake/etcd
3 participants
@mitake @ekle @heyitsanthony