Skip to content

Commit

Permalink
Makefile: bump up default Go version to 1.14.3
Browse files Browse the repository at this point in the history 
Signed-off-by: Gyuho Lee <[email protected]>
  • Loading branch information
@gyuho
gyuho committed May 15, 2020
1 parent 2c7670f commit 93de725
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ docker-remove:



GO_VERSION ?= 1.14.2
GO_VERSION ?= 1.14.3

This comment has been minimized.

Sign in to view

Copy link
@liggitt

liggitt May 19, 2020

Contributor

how is this working with the bbolt issues reported in etcd-io/bbolt#187 and etcd-io/bbolt#214?

cc @jpbetz
ETCD_VERSION ?= $(shell git rev-parse --short HEAD || echo "GitNotFound")

TEST_SUFFIX = $(shell date +%s | base64 | head -c 15)
Expand All @@ -63,11 +63,11 @@ endif


# Example:
# GO_VERSION=1.14.2 make build-docker-test
# GO_VERSION=1.14.3 make build-docker-test
# make build-docker-test
#
# gcloud docker -- login -u _json_key -p "$(cat /etc/gcp-key-etcd-development.json)" https://gcr.io
# GO_VERSION=1.14.2 make push-docker-test
# GO_VERSION=1.14.3 make push-docker-test
# make push-docker-test
#
# gsutil -m acl ch -u allUsers:R -r gs://artifacts.etcd-development.appspot.com
Expand Down

0 comments on commit 93de725

Please sign in to comment.