-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
clientv3: make balancer respect FastFail
The simpleBalancer.Get() blocks grpc.Invoke() even when the Invoke() is called with the FailFast option. Therefore currently any requests with the FastFail option actually doesn't fail fast. They get blocked when there is no endpoints available. Get() method needs to respect the BlockingWait option when picks up an endpoint address from the list and fail immediately when the option is enabled and no endpoint is available.
- Loading branch information
Showing
6 changed files
with
144 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| // Copyright 2016 The etcd Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package clientv3 | ||
|
|
||
| import ( | ||
| "errors" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "golang.org/x/net/context" | ||
| "google.golang.org/grpc" | ||
| ) | ||
|
|
||
| var ( | ||
| endpoints = []string{"localhost:2379", "localhost:22379", "localhost:32379"} | ||
| ) | ||
|
|
||
| func TestBalancerGetUnblocking(t *testing.T) { | ||
| sb := newSimpleBalancer(endpoints) | ||
| unblockingOpts := grpc.BalancerGetOptions{BlockingWait: false} | ||
|
|
||
| _, _, err := sb.Get(context.Background(), unblockingOpts) | ||
| if err != ErrNoAddrAvilable { | ||
| t.Errorf("Get() with no up endpoints should return ErrNoAddrAvailable, got: %v", err) | ||
| } | ||
|
|
||
| down1 := sb.Up(grpc.Address{Addr: endpoints[1]}) | ||
| down2 := sb.Up(grpc.Address{Addr: endpoints[2]}) | ||
| addrFirst, putFun, err := sb.Get(context.Background(), unblockingOpts) | ||
| if err != nil { | ||
| t.Errorf("Get() with up endpoints should sucess, got %v", err) | ||
| } | ||
| if addrFirst.Addr != endpoints[1] && addrFirst.Addr != endpoints[2] { | ||
| t.Errorf("Get() didn't return expected address, got %v", addrFirst) | ||
| } | ||
| if putFun == nil { | ||
| t.Errorf("Get() returned unexpected nil put function") | ||
| } | ||
| addrSecond, _, _ := sb.Get(context.Background(), unblockingOpts) | ||
| if addrSecond.Addr != addrSecond.Addr { | ||
| t.Errorf("Get() didn't return the same address as previous call, got %v and %v", addrFirst, addrSecond) | ||
| } | ||
|
|
||
| down1(errors.New("error")) | ||
| down2(errors.New("error")) | ||
| _, _, err = sb.Get(context.Background(), unblockingOpts) | ||
| if err != ErrNoAddrAvilable { | ||
| t.Errorf("Get() with no up endpoints should return ErrNoAddrAvailable, got: %v", err) | ||
| } | ||
| } | ||
|
|
||
| func TestBalancerGetBlocking(t *testing.T) { | ||
| sb := newSimpleBalancer(endpoints) | ||
| blockingOpts := grpc.BalancerGetOptions{BlockingWait: true} | ||
|
|
||
| ctx, _ := context.WithTimeout(context.Background(), time.Millisecond*100) | ||
| _, _, err := sb.Get(ctx, blockingOpts) | ||
| if err != context.DeadlineExceeded { | ||
| t.Errorf("Get() with no up endpoints should timeout, got %v", err) | ||
| } | ||
|
|
||
| downC := make(chan func(error), 1) | ||
|
|
||
| go func() { | ||
| // ensure sb.Up() will be called after sb.Get() to see if Up() releases blocking Get() | ||
| time.Sleep(time.Millisecond * 100) | ||
| downC <- sb.Up(grpc.Address{Addr: endpoints[1]}) | ||
| }() | ||
| addrFirst, putFun, err := sb.Get(context.Background(), blockingOpts) | ||
| if err != nil { | ||
| t.Errorf("Get() with up endpoints should sucess, got %v", err) | ||
| } | ||
| if addrFirst.Addr != endpoints[1] { | ||
| t.Errorf("Get() didn't return expected address, got %v", addrFirst) | ||
| } | ||
| if putFun == nil { | ||
| t.Errorf("Get() returned unexpected nil put function") | ||
| } | ||
| down1 := <-downC | ||
|
|
||
| down2 := sb.Up(grpc.Address{Addr: endpoints[2]}) | ||
| addrSecond, _, _ := sb.Get(context.Background(), blockingOpts) | ||
| if addrSecond.Addr != addrSecond.Addr { | ||
| t.Errorf("Get() didn't return the same address as previous call, got %v and %v", addrFirst, addrSecond) | ||
| } | ||
|
|
||
| down1(errors.New("error")) | ||
| down2(errors.New("error")) | ||
| ctx, _ = context.WithTimeout(context.Background(), time.Millisecond*100) | ||
| _, _, err = sb.Get(ctx, blockingOpts) | ||
| if err != context.DeadlineExceeded { | ||
| t.Errorf("Get() with no up endpoints should timeout, got %v", err) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters