Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use cobra exactArgs #728

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: use cobra exactArgs #728

merged 1 commit into from
Apr 17, 2024

Conversation

Elbehery
Copy link
Member

@Elbehery
fix: use cobra exactArgs
2fe6b63 
Signed-off-by: Mustafa Elbehery <[email protected]>
@Elbehery Elbehery mentioned this pull request Apr 17, 2024
Merged
ahrtr
ahrtr approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@Elbehery
Copy link
Member Author

@ahrtr we should wait for #723 to merge first, so that i adjust it accordingly in this PR 🙏🏽

@Elbehery
Copy link
Member Author

/hold

@ahrtr
Copy link
Member

ahrtr commented Apr 17, 2024

@ahrtr we should wait for #723 to merge first, so that i adjust it accordingly in this PR 🙏🏽

This PR is straightforward, I think it can be merged once the test green.
Afterwards please rebase #723.

@ahrtr ahrtr merged commit cc22218 into etcd-io:main Apr 17, 2024
15 checks passed
@Elbehery Elbehery self-assigned this Apr 17, 2024
tjungblu pushed a commit to tjungblu/bbolt that referenced this pull request Apr 18, 2024
@ahrtr @tjungblu
Merge pull request etcd-io#728 from Elbehery/use_cobra_exactArgs
09f4ff6 
fix: use cobra exactArgs
@Elbehery Elbehery deleted the use_cobra_exactArgs branch April 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees

@Elbehery Elbehery

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use cobra ExactArgs
2 participants
@Elbehery @ahrtr