fix: pgid initial state #642
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Elbehery <[email protected]>
fuweid
reviewed
Dec 18, 2023
| @@ -85,7 +85,7 @@ func (tx *Tx) checkBucket(b *Bucket, reachable map[common.Pgid]*common.Page, fre | |||
| } | |||
|
|
|||
| // Ensure each page is only referenced once. | |||
| for i := common.Pgid(0); i <= common.Pgid(p.Overflow()); i++ { | |||
| for i := common.Pgid(p.Id()); i <= common.Pgid(p.Overflow()); i++ { | |||
| var id = p.Id() + i | |||
There was a problem hiding this comment.
I don't think so. id has p.Id() as base
There was a problem hiding this comment.
yes exactly, the base should be Pgid(p.Id())
currently, it is Pgid(0) regardless of the rootPageId we starting from this specific func call
please correct me if i misunderstanding :)
There was a problem hiding this comment.
The change isn't correct. Let's work with an example,
Assuming p.Id() == 100, and overflow == 3, then we need to iterate pages: 100, 101, 102.
There was a problem hiding this comment.
ahhhh i got it now, p.Overflow() contains count, not the pageIds 👍🏽
sorry my bad 👍🏽
|
READ #642 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while working on #580
Pgid initial state was sat to
0, while the code here traverses the bucket & sub-buckets, it should start from the currentpgidcc @ahrtr @fuweid