Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make smembers isMasterOnly = false #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fehmicansaglam
Copy link
Contributor

Fixes #231
SMEMBERS is a read only command therefore it should be run on slaves.

SMEMBERS is a read only command therefore it should be run on slaves.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 90.508% when pulling fcfc71d on fehmicansaglam:master into 5600b00 on etaty:master.

@farico
Copy link

farico commented Dec 31, 2019

any updates on this PR and issue @etaty ?

@farico
Copy link

farico commented Dec 31, 2019

Temporary solution would be to use slavesClients directly on RedisClientMasterSlaves:

val redis = RedisClientMasterSlaves(...)
redis.slavesClients.smembers() // send SMEMBERS to replicas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smembers is set as isMasterOnly = true
3 participants