Optional connect timeout for RedisClient & RedisBlockingClient #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid blocking all cache calls until default akka TCP timeout kicks in. Also, changing RedisClientActor instantiation to recommended type safe method.
|
Is there any progress on this? Im wondering if this would help our use case of failing gracefully when redis is unavailable. Currently all redis calls take 2 seconds to timeout which is a hardcoded value (https://github.com/etaty/rediscala/blob/master/src/main/scala/redis/actors/RedisWorkerIO.scala#L179) which is quite high especially since our use case is to use redis as a cache. |
|
This is similar to #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional connect timeout for RedisClient & RedisBlockingClient to avoid blocking all cache calls until default akka TCP timeout kicks in.
Also, changing RedisClientActor instantiation to recommended type safe method.