Remove numpy asfarray and float_ usage to support v2.0 deprecation
#934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhas-r
force-pushed
the
support-numpy-2.0
branch
from
d1330d4 to
4471d04
Compare
suhas-r
changed the title
asfarray and float_ usage to support v2.0 deprecation
etal
approved these changes
Jan 16, 2025
|
Fantastic, thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
np.asfarray+np.float_were removed in Numpy-2.0.0 (release notes), in favor of usingnp.asarray/np.float64, respectively. np.asarray + np.float64 are available i existingnumpy>=1.24.2versions currently required by the cnvkit conda env.cnvkit otherwise functions properly with
numpy-2.*andpython-3.12after updating these methods.