-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in script to check if LogRocket integrity has changed #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing old paths as we now directly will include LR
Updating the licsense list Removing LogRocket from package
Updating types Updating logging
@skord - adding you as an FYI |
script
with integrity
Ran a small set of manual tests and the command functions as expected thus far. I needed to update the version of the Let me know if any changes arise past this point that you would like me to review. |
Marking command as beta
Adding license for new dep
script
with integrity
kiahna-tucker
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#866
Changes
866
logRocketIntegrity
script to check that we are using the latestChanged to load in LogRocket manually through injecting a script tagreverted.env
properties for LogRocket integrityAdded section to the read merevertedTests
Manually tested
Automated tests
Screenshots
If the latest hash is being used

If an update is required

If the main

catch
is hit