Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in script to check if LogRocket integrity has changed #914

Merged
merged 26 commits into from
Jan 8, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Jan 3, 2024

Issues

#866

Changes

866

  • Added a logRocketIntegrity script to check that we are using the latest
  • Changed to load in LogRocket manually through injecting a script tag reverted
  • Added .env properties for LogRocket integrity
  • Added section to the read mereverted

Tests

Manually tested

  • Manually tested for using old sha, latest sha, and failed to load
  • Hit the page with Log Rocket enabled and disabled

Automated tests

  • n/a

Screenshots

If the latest hash is being used
image

If an update is required
image

If the main catch is hit
image

@travjenkins
Copy link
Member Author

@skord - adding you as an FYI

@travjenkins travjenkins changed the title Travjenkins/deps/inline log rocket Load Log Rocket with script with integrity Jan 3, 2024
@kiahna-tucker
Copy link
Member

Ran a small set of manual tests and the command functions as expected thus far. I needed to update the version of the node CLI to v20.10.0 since the --env-file option was introduced recently.

Let me know if any changes arise past this point that you would like me to review.

@travjenkins travjenkins changed the title Load Log Rocket with script with integrity Add in script to check if LogRocket integrity has changed Jan 5, 2024
@travjenkins travjenkins marked this pull request as ready for review January 5, 2024 21:14
@travjenkins travjenkins requested a review from a team as a code owner January 5, 2024 21:14
@travjenkins travjenkins merged commit 98ae340 into main Jan 8, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/deps/inlineLogRocket branch January 8, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants