Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prod: check existence of collection metadata in store action #1477

Merged

Conversation

kiahna-tucker
Copy link
Member

@kiahna-tucker kiahna-tucker commented Feb 26, 2025

Issues

The issues directly below are advanced by this PR:
#1409

Changes

1409

The following features are included in this PR:

  • Ensure that target collection metadata exists before indexing in binding store action, setSourceBackfillRecommended.

Tests

Manually tested

Approaches to testing are as follows:

  • Validate that the top-level, Backfill toggle button can be unset, an error is not encountered, and the form returns to an idle state.

Automated tests

N/A

Playwright tests ran locally

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

N/A

@kiahna-tucker kiahna-tucker marked this pull request as ready for review February 26, 2025 18:53
@kiahna-tucker kiahna-tucker requested a review from a team as a code owner February 26, 2025 18:53
Copy link
Member

@travjenkins travjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm... we should probably put some extra effort to create a new helper type that does not complain about this kinda thing.

@kiahna-tucker kiahna-tucker merged commit 9f6fc05 into main Feb 26, 2025
3 checks passed
@kiahna-tucker kiahna-tucker deleted the kiahna-tucker/bug-repair/unset-backfill-all-button branch February 26, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants