Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: msw temporary fix for audit issues #1253

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Sep 10, 2024

Issues

npm audit highlighted an issue with msw depending on path-to-regexp

mswjs/msw#2270 (comment) mentioned a possible fix for the issue while msw works on a full fix.

Changes

misc

  • Added override to package

Tests

Manually tested

  • scenarios you manually tested

Automated tests

  • ran unit tests and they all passed

Playwright tests ran locally

N/A

  • Admin
  • Captures
  • Collections
  • HomePage
  • Login
  • Materialization

Screenshots

Unit Tests

image

image

@travjenkins travjenkins added the change:unplanned Unplanned change, useful for things like doc updates label Sep 10, 2024
@travjenkins travjenkins added the tech debt Placeholder for work that is invisible to the user label Sep 10, 2024
@travjenkins travjenkins marked this pull request as ready for review September 10, 2024 16:47
@travjenkins travjenkins requested a review from a team as a code owner September 10, 2024 16:47
Copy link
Member

@kiahna-tucker kiahna-tucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without manual testing.

Removing deprecated install command
@travjenkins travjenkins added dependencies Pull requests that update a dependency file and removed tech debt Placeholder for work that is invisible to the user labels Sep 10, 2024
@travjenkins travjenkins merged commit 704aa5c into main Sep 10, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/deps/2024-10_audit-issue branch September 10, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned Unplanned change, useful for things like doc updates dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants