Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to the AICPA site for the SOC2 logo #613

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

travjenkins
Copy link
Member

Changes

  • We need to link to this site from the logo so just wrapping the entire image as it is not broken up.

Tests / Screenshots

  • scenarios you tested with screenshots

Copy link

github-actions bot commented Jan 2, 2025

Visit the preview URL for this PR (updated for commit 72e67be):

https://estuary-marketing--pr613-travjenkins-content-c5qeyssu.web.app

(expires Sat, 01 Feb 2025 20:34:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 76f6b095a0752e5d9c6c890267f9fdc3e392161e

@Brenosalv
Copy link
Collaborator

Brenosalv commented Jan 2, 2025

In terms of UX, it doesn't look clear that there is a link attached to the image. Maybe a button below the current button would look better. Just a suggestion in case this link is very important to be clicked.

Copy link
Collaborator

@Brenosalv Brenosalv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@travjenkins travjenkins merged commit 8abc0e4 into master Jan 2, 2025
15 checks passed
@travjenkins travjenkins deleted the travjenkins/content/remove-soc-logo branch January 2, 2025 21:33
@travjenkins
Copy link
Member Author

I agree this UX isn't super clear - I'm gonna convert the original task to handle that work

#612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants