Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: sanitize draft error messages before persisting #1885

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

psFried
Copy link
Member

@psFried psFried commented Jan 21, 2025

Postgres text columns cannot store strings containing a null byte. This sanitizes error messages by replacing null bytes with the unicode replacement character, so that they can be stored in the database.


This change is Reviewable

Postgres text columns cannot store strings containing a null byte. This
sanitizes error messages by replacing null bytes with the unicode replacement
character, so that they can be stored in the database.
@psFried psFried added bug Something isn't working control-plane labels Jan 21, 2025
@psFried psFried requested a review from mdibaiee January 21, 2025 12:53
Copy link
Member

@mdibaiee mdibaiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Phil

@psFried psFried merged commit d04668a into master Jan 21, 2025
3 checks passed
@psFried psFried deleted the phil/sanitize-errors branch January 21, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working control-plane
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants