Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phil/update gazette #1160

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Phil/update gazette #1160

merged 2 commits into from
Aug 23, 2023

Conversation

psFried
Copy link
Member

@psFried psFried commented Aug 23, 2023 •
edited by jgraettinger
Loading

Description:

Rolls up a couple of miscellaneous fixes.

@skord, this ought to fix the shards prune errors, so we should be good to try that job again after this merges

This change is Reviewable

psFried added 2 commits August 23, 2023 09:58
@psFried
update proto-gazette generated code
318bd52 
Updates the checked-in proto-gazette code to reflect the changes introduced in #1150
@psFried
update gazette to latest master
ae75cb3 
This is to pull in a few fixes from gazette/core#347
@psFried psFried requested a review from jgraettinger August 23, 2023 14:03
jgraettinger
jgraettinger approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psFried psFried merged commit 052a1c4 into master Aug 23, 2023
@psFried psFried deleted the phil/update-gazette branch August 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraettinger jgraettinger jgraettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psFried @jgraettinger