prevent infinite traversal when passed cyclic structures

[uni-zheng]

When traverse unlisted keys, estraverse will iteraction this node all properties.

I think in most cases the property parent is used to reference parent node.

So I exclude parent in iteraction.

This issue was discovered while using esquery, esquery use estraverse directly without set fallback.

[michaelficarra]

What tools produce parent links like this? As far as the solution goes, I'd much prefer using a seen list to this special-casing of a property named "parent".

[uni-zheng]

@michaelficarra I know there is known keys list to find which property to access.

But estraverse has issue to handle unknown keys.

I use ESLint with babel-eslint parser to check my code. There has a loop when query unknown key JSXOpeningElement.

As current method that it will map all properties on unknown key to find chilren which has type prop.

[michaelficarra]

@uni-zheng I don't think you're understanding. I believe you that nodes with self-references or circular references exist. I think the best way to account for this is keeping track of nodes that have been traversed to avoid traversing them more than once.

[uni-zheng]

@michaelficarra You're right. I updated codes.

[michaelficarra]

@uni-zheng Thanks for the contribution!

[uni-zheng]

@michaelficarra Hi, I am glad to complete this contribution.

And I checked [email protected] there still use [email protected] code in npm. Could you release a new version for esquery include this codes?

[michaelficarra]

@uni-zheng Sure, can you open an issue on esquery?