feat: change name #345
Closed
feat: change name #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry wrong repo. |
|
just pushed 1.3.0 to crates.io fyi... we found a last minute regression and fixed it |
4 tasks
SWvheerden
pushed a commit
to tari-project/tari
that referenced
this pull request
Feb 15, 2024
Description --- Switch to log4rs 1.3 Motivation and Context --- tari-project/log4rs#1 estk/log4rs#345 It appears that the log4rs commits arent used since the cargo.lock rev was set to commit [`e1051fd3a1bec9c55d055f60176a96cf11e58505`](tari-project/log4rs@e1051fd) https://github.com/tari-project/log4rs/commits/master/#:r3d:-listview-node-:r3e: and the crate was renamed to tari_log4rs. This rename will only break the current build if the cargo.lock is updated. Since no rev or tag is used, current `master` would be used. @SWvheerden Please verify the changes are in [email protected] that were required. Just this right? https://github.com/estk/log4rs/blob/c981ca4e2126c5728505c562b34926f9a9fad00b/Cargo.toml#L59 Breaking Changes --- - [x] None - [ ] Requires data directory on base node to be deleted - [ ] Requires hard fork - [ ] Other - Please specify <!-- Does this include a breaking change? If so, include this line as a footer --> <!-- BREAKING CHANGE: Description what the user should do, e.g. delete a database, resync the chain -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the name of this fork to tari_log4rs so we can push this up to crates.io