Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deprecated merge_imports && fmt #327

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

SteveLauC
Copy link
Contributor

What does this PR do

  1. merge_imports is deprecated now, update it to imports_granularity.
  2. Format code

@bconn98
Copy link
Collaborator

bconn98 commented Dec 5, 2023

Reference: rust-lang/rustfmt#3362 for context. Change looks good to me. The fmt output looks no different to me

cargo fmt -- --check
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.

@bconn98
Copy link
Collaborator

bconn98 commented Dec 5, 2023

I'll fix the above warning in my CI branch.

@SteveLauC
Copy link
Contributor Author

Yeah, this feature needs a nightly toolchain

@estk
Copy link
Owner

estk commented Dec 6, 2023

🎉

@estk estk enabled auto-merge (squash) December 6, 2023 01:47
@estk estk merged commit 1bdb7e7 into estk:main Dec 6, 2023
10 checks passed
@SteveLauC SteveLauC deleted the fmt_merge branch December 6, 2023 01:54
bconn98 pushed a commit to bconn98/log4rs that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants