Add support for AWS China's different domain suffix #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a copy policy that actually does copying, everything works, the authorization tokens have the https://012345678910.dkr.ecr... URL. Unfortunately, that looks like it's the only way to ask the SDK to generate a URL for you, so this won't do anything for anyone who wants to use the other Special AWS Environment, govcloud, and wants FIPS URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, this doesn't show up unless you are in "no copy" mode- it looks like in copy mode, k8s-image-mapper gets the docker URI from the authorization token, passes it through skopeo, and get it back, but where we're forced to generate the domain, we need a little extra magic.