Ensure using GNU tar for GitHub Releases #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qryxip
changed the title
gtar for GitHub Releases
|
So if I understand this correctly, there is a GNU custom extension to the tar file format that the tar crate can't read, right? So I suppose GNU tar creates tar files using that extension? So why make Mac OS use it? Wouldn't that be the opposite of what we need? |
|
Sorry for late response. To come to the point, this PR is no longer needed. The problem of cargo-binstall is already resolved because they forked tar-rs and fixed it. I don't fully understand, but it seems to be actually a bug of tar-rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cargo-binstall cannot be used for cargo-udeps on macOS due to alexcrichton/tar-rs#295.