Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dark Theme #11

Closed
ghost opened this issue Sep 5, 2014 · 2 comments
Closed

Support for Dark Theme #11

ghost opened this issue Sep 5, 2014 · 2 comments
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Sep 5, 2014

Is it possible to provide some kind of support for Dark Theme (even some settings if detecting color is troublesome). Everything looks fine, except fields for properties values. They look like hard-coded white. Take a look:
send

[EDIT]
What more, I've noticed that fields go dark when change theme to Dark Theme. But as soon as I press save button to save the changes with property editor, fields go white.

@ghost ghost closed this as completed Sep 5, 2014
@ghost ghost reopened this Sep 5, 2014
@ghost ghost closed this as completed Sep 5, 2014
@ghost ghost reopened this Sep 5, 2014
@essiembre
Copy link
Owner

It is indeed hard coded to white. I removed setting the color explicitly (should not use default theme/OS colors). My testing still showed a white background regardless. If you think that's wrong, I think the Eclipse SWT StyledText component used may not use theme colors. In which case, I am not too sure how to go about it to tell it to use the "right" colors. Fix will be in next release.

@essiembre essiembre added this to the 1.0.4 milestone Oct 12, 2014
@essiembre essiembre self-assigned this Oct 12, 2014
@essiembre
Copy link
Owner

1.0.4 Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant