Improve Skip Builds Handling on Build CLI & Disable TLS Initial on Jemalloc #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use serde for loading & saving the file instead of the manual parsing * Additional features on the last run are involved in the persisted states * Use one file for states instead of two for development and production by including the production state in the file itself * Rename the module and structs for the build records * Move additional features to thier own module * Add new build state file name to gitignore
Adjust the integration tests with the new changes on the reset command
Jemalloc combined with Node.js exceeds the default TLS memory limit on Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2152
Build CLI Tool:
This PR improves tracking the state of the last build to determine which builds can be skipped by:
serdeto write and parse the file instead of the manually implementation previously, enabling adding more information to the build state without having to change the parse code.Jemalloc Memory Allocator:
This PR disable initial allocating TLS memory because it leads to Chipmunk exceeding the allowed TLS memory for a process on Linux machine when it run combined with NodeJS and Electron