Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust dependencies (Core, Bindings, Build CLI) #2150

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

AmmarAbouZor
Copy link
Member

@AmmarAbouZor AmmarAbouZor commented Nov 18, 2024

This PR updates the rust dependencies among Chipmunk libraries and tools

Only pcap-parser and etherparse couldn't be updated because they introduced breaking changes on their API.

Update:

  • Clippy fixes for Rust version 1.83.0 are included in this PR
  • PR rebased on master after merging pcap dependencies updates

@AmmarAbouZor AmmarAbouZor marked this pull request as ready for review November 21, 2024 09:21
@AmmarAbouZor AmmarAbouZor requested a review from marcmo November 21, 2024 09:21
* Improve dependencies declaration in `Cargo.toml` according to semver
  rules.
* Update dependencies to latest version in `Cargo.toml`
* Run `Cargo update` command
* Update Rust dependencies to their latest version in Rust Core,
  add-ons and Indexer CLI tool
* Update dependencies in Build CLI tool
@AmmarAbouZor
Copy link
Member Author

Hi @DmitryAstafyev
I've rebased this PR on the top of master and added clippy fixes for Rust version 1.83

Copy link
Collaborator

@DmitryAstafyev DmitryAstafyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a couple of tiny notes

application/apps/indexer/sources/Cargo.toml Outdated Show resolved Hide resolved
parsers = { path = "../parsers" }
processor = { path = "../processor" }
rustc-hash = "1.1"
rustc-hash = "2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use the same approach as for others "x.x"

application/apps/indexer/Cargo.toml Outdated Show resolved Hide resolved
application/apps/indexer/Cargo.toml Outdated Show resolved Hide resolved
Set all versions' format to xx.xx to make it as a standard for all dependencies
@AmmarAbouZor AmmarAbouZor merged commit 642540a into esrlabs:master Dec 3, 2024
2 checks passed
@AmmarAbouZor AmmarAbouZor deleted the update_dependencies branch December 3, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants