Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of #644 #654

Merged
merged 12 commits into from
Sep 21, 2024
Merged

Review of #644 #654

merged 12 commits into from
Sep 21, 2024

Conversation

matjack1
Copy link
Collaborator

@matjack1 matjack1 commented Sep 21, 2024

Since the PR #644 was abandoned I've finished the review myself, and here it is.

mainly these things are changed/added:

  • more mqtt data is send (pincode for example) and ha discovery for that added (easier to integrate in ha with alarmo, yu can use the pincode from esp-rfid for arm/disarm alarmo)
  • systemname is shown on status page and in the menu under the esp-rfid-icon (makes it more easier to manage if you have more than one device)
  • uptime on status page human readable see issue Improve rendering of uptime in web UI #607

@matjack1
Copy link
Collaborator Author

Thank you @pvtex for the bulk of the work here! :)

@matjack1 matjack1 merged commit 703e799 into dev Sep 21, 2024
4 checks passed
@matjack1 matjack1 deleted the v2.0.x branch September 21, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants