Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignored timezone in web UI #540

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix ignored timezone in web UI #540

merged 1 commit into from
Oct 28, 2022

Conversation

matjack1
Copy link
Collaborator

In the UI, the device time wasn't using the timezone set in the configuration, but always the UTC date time.

@omersiar
Copy link
Collaborator

I remember this is because global summer time and politics around it changes all the time. Keeping time as utc internally and adjusting it according the changes makes more sense.

@matjack1
Copy link
Collaborator Author

I agree with you, it's just a different way to show in that particular part of the UI, I think it's useful to the user setting that option, to understand if the timezone is correct.

Since we are not handling summer time, it's more difficult to understand if you've picked the right timezone

@omersiar
Copy link
Collaborator

Thanks ☺️

@matjack1 matjack1 merged commit 5998410 into dev Oct 28, 2022
@matjack1 matjack1 deleted the fix-timezone branch November 6, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants