Refactor Wiegand reading function #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To remove duplicated code in RFID reading section.
|
neat, thanks for your work. 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add some functionality to the Wiegand reader and I've noticed that the code is duplicated between the official board and the others.
In extracting the code in the function I've minimized the changes.
While doing so I've also found a bug when using the keypad as a return statement was commented out, for every keypress the function was going ahead and testing if the user was in the memory, even if the uid wasn't filled in.
I don't have yet an official board to test (soon though!), but the code is building properly.