Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logfile fixes part2 #314

Merged
merged 3 commits into from
Sep 8, 2019
Merged

Logfile fixes part2 #314

merged 3 commits into from
Sep 8, 2019

Conversation

frenchie71
Copy link
Contributor

Adding automatic maintenance options to the config json
Adding a Downoad Button for logfiles
Adding Maintenance functions rollover, split, delete, view for logfiles
Adding Log File Maintenance Section for FileList on SPIFFS to the UI

@frenchie71
Copy link
Contributor Author

should fix most of #285 - automatic functions need to be implemented still

Copy link
Collaborator

@omersiar omersiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great implementation, this was the original plan. Nicely done. 👍

@omersiar omersiar merged commit 6ff5887 into esprfid:dev Sep 8, 2019
@frenchie71
Copy link
Contributor Author

Thank you - there are a handful of caveats though at the moment

  • Split is blocking, i.e. there is no User Interface Update on the progress but it does not trigger the watchdog - and it is reasonably fast (roughly 10 sec for a 100K logfile)

  • Corrupt logfiles will not load correctly. This is caused by at least three things:

  • the JSON.parse in the esprfid.js throws an error if it can't convert

  • the ws.textAll in log.esp throws an error if there are garbage characters - the client will wait eternally for the next page

  • the SPIFFS readStringUntil is blocking and does not stop if it reads upon EOF. This will definitely trigger the watchdog and reset the unit

I might work on these in the next couple of days or weeks ;-)

@frenchie71 frenchie71 deleted the logfile-fix branch September 8, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants