Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor waLBerla bridge #4864

Merged
merged 7 commits into from
Feb 26, 2024
Merged

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Feb 21, 2024

Fixes #4859, fixes #4855

Description of changes:

  • bugfix:
  • performance:
    • the LB flag field is no longer communicated at every time step
    • the LB UBB field is no longer recalculated at every time step
    • LB boundary setters (node, slice, shape) now always trigger a full ghost communication
  • maintainability:
    • the waLBerla header files are no longer visible in the ESPResSo core and script interface
    • the Boost dependency is now checked at the CMake level to prevent building broken ESPResSo shared libraries (see details in Undefined behavior from static global variables #4856)

Split LB ghost communicator from LB boundaries communicator.
Always communicate bounce-back velocities from the ghost layer.
This fixes the regression introduced by
3fd1709.
@jngrad jngrad force-pushed the walberla_refactor branch 2 times, most recently from 912c46f to 0a90a87 Compare February 21, 2024 17:56
Boost 1.84 is not supported. Drop the macOS CI job: Homebrew only
provides a recipe for boost-mpi version 1.84.
@jngrad jngrad added the automerge Merge with kodiak label Feb 26, 2024
@kodiakhq kodiakhq bot merged commit 2e7b11b into espressomd:python Feb 26, 2024
10 checks passed
@jngrad jngrad deleted the walberla_refactor branch February 26, 2024 10:26
@reinaual reinaual added the waLBerla Issues regarding waLBerla integration label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak BugFix CodeQuality Core Performance waLBerla Issues regarding waLBerla integration
Projects
None yet
3 participants