Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thermostat cleanup #4743

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Thermostat cleanup #4743

merged 2 commits into from
Jun 13, 2023

Conversation

christophlohrmann
Copy link
Contributor

Fixes #3734

Description of changes:

  • use particle-specific gamma in LB
  • check that particle gamma is not anisotropic (not supported by LB)
  • update test with more 'physical' paameters

jngrad
jngrad requested changes Jun 12, 2023
View reviewed changes
src/core/thermostat.cpp Outdated Show resolved Hide resolved
src/core/grid_based_algorithms/lb_particle_coupling.cpp Outdated Show resolved Hide resolved
testsuite/python/lb_thermostat.py Outdated Show resolved Hide resolved
@jngrad jngrad self-assigned this Jun 12, 2023
@jngrad jngrad force-pushed the thermostat_cleanup branch from 431aa34 to 3c2cb0b Compare June 13, 2023 11:25
jngrad
jngrad approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 1b646ef into espressomd:python Jun 13, 2023
@jngrad jngrad added this to the ESPResSo 4.3.0 milestone Jun 13, 2023
@jngrad jngrad mentioned this pull request Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees

@jngrad jngrad

Labels
automerge Merge with kodiak Core Improvement
Projects
None yet
Milestone
ESPResSo 4.3.0
Development

Successfully merging this pull request may close these issues.

LB coupling should use per particle gamma
2 participants
@christophlohrmann @jngrad