Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI reports #4736

Merged
merged 2 commits into from
May 24, 2023
Merged

Fix CI reports #4736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02712bb
CI: Use GitLab canonical URLs
jngrad May 24, 2023
0d909b4
tests: Provide a meaningful error message
jngrad May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion maintainer/gh_create_issue.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#

URL="https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/pipelines/${CI_PIPELINE_ID}"
URL="https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/pipelines/${CI_PIPELINE_ID}"

curl -s "https://api.github.com/repos/espressomd/espresso/issues" \
-H "Accept: application/vnd.github.full+json" \
Expand Down
2 changes: 1 addition & 1 deletion maintainer/gh_post_status.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
[ "${#}" -eq 1 ] || exit 1

GIT_COMMIT=$(git rev-parse HEAD)
URL="https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/pipelines/${CI_PIPELINE_ID}"
URL="https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/pipelines/${CI_PIPELINE_ID}"
STATUS="${1}"
curl "https://api.github.com/repos/espressomd/espresso/statuses/${GIT_COMMIT}" \
-H "Authorization: token ${GITHUB_TOKEN}" \
Expand Down
10 changes: 8 additions & 2 deletions testsuite/python/sigint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@
import os


EXPECTED_TRACEBACK_ENDING = """ in handle_sigint
signal.raise_signal(signal.Signals.SIGINT)
KeyboardInterrupt
"""


class SigintTest(ut.TestCase):

script = str(pathlib.Path(__file__).parent / 'sigint_child.py')
Expand All @@ -43,8 +49,8 @@ def check_signal_handling(self, process, sig):
self.assertEqual(traceback, "")
elif sig == signal.Signals.SIGINT:
self.assertIn(" self.integrator.run(", traceback)
self.assertTrue(traceback.endswith(
" in handle_sigint\n signal.raise_signal(signal.Signals.SIGINT)\nKeyboardInterrupt\n"))
self.assertTrue(traceback.endswith(EXPECTED_TRACEBACK_ENDING),
msg=f"Traceback failed string match:\n{traceback}")

def test_signal_handling(self):
signals = [signal.Signals.SIGINT, signal.Signals.SIGTERM]
Expand Down