-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building PPA Package for ESPResSo #4664
Open
bishwash369
wants to merge
37
commits into
espressomd:python
Choose a base branch
from
bishwash369:python-test
base: python
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngrad
reviewed
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! I have a few general questions:
- can the workflow re-use the publish-ppa-package workflow directly from the marketplace to avoid code duplication?
- using marketplace workflows helps a lot with code maintenance, security alerts, integration in the GitHub ecosystem, and allows us to give more credit to the authors of workflows
- if the code duplication was required to extend the workflow functionality, we could propose these extensions upstream
- is there a way to control the CMake command that is invoked by the PPA build? This would be helpful to select which external features are enabled. Also, the default CMake command currently contains
-DCMAKE_BUILD_TYPE=None
, which emits a warning in our custom CMake functions, but in the future this warning might become a fatal error. - is there a way to run the ESPResSo unit tests and python tests during the PPA build? This is the standard procedure on Fedora and OpenSUSE to block the release of broken ESPResSo builds. It helped us detect stealthy bugs that would only be triggered by very specific test cases due to floating-point precision errors and MPI communications errors.
- there are a few minor issues with Ubuntu package dependencies that I can take care of
- we officially no longer support 32bit architectures (e.g.
i386
) and Ubuntu versions older than 20.04; I would suggest you skip all architectures except foramd64
- the CMake package dependency issue that you see on Ubuntu 20.04 has a workaround that we use in our automatic build pipelines: we pip install a more recent CMake version as a regular user. I have never tried it in a packaging build system, though. It should not be an issue for the build, since CMake is just a dependency of the build process, and not of the package itself. However if the Pypi repositories are not accessible from within the build pipeline, then we cannot support the PPA on Ubuntu 20.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description of changes: