Fix regressions in auto-exclusions #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinaual
approved these changes
Jan 19, 2023
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Jan 19, 2023
The bond length is no longer misinterpreted as a bond id (fixes bug introduced by a48ed7c). Fixes espressomd#4652 Description of changes: - the feature now works with non-contiguous particle ids - the feature no longer adds spurious exclusions to particle ids in the range `[1, distance]` - completely rewrite the test case to check all topologies and regular decompositions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4652
Fixes #4650
Description of changes:
[1, distance]