Update type map when clearing the particle list #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing feature guards, use subtests.
reinaual
approved these changes
Jan 12, 2023
jngrad
added
automerge
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Jan 19, 2023
Fixes espressomd#4644 Fixes espressomd#4645 Description of changes: - bugfix: the type map is now properly updated when clearing particles - add missing feature guards in the testsuite - add subtests to provide more context when a test fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4644
Fixes #4645
Pre-requisite to #4629
Description of changes: