Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve support for CUDA libraries and FetchContent #4642

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Improve support for CUDA libraries and FetchContent #4642

merged 2 commits into from
Jan 9, 2023

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Dec 28, 2022

Description of changes:

  • restrict Clang-Tidy checks to the main project
    • external libraries obtained via FetchContent and their consumer targets in ESPResSo no longer emit diagnostics
  • use native CUDA support in CMake 3.22
    • project option ESPRESSO_CUDA_COMPILER was removed
    • the waLBerla library obtained via FetchContent can now be compiled with WALBERLA_BUILD_WITH_CUDA=ON
    • the CUDA 11 circular dependency in Ubuntu 22.04 packages is now documented (closes Using GCC and Clang with CUDA 11 on Ubuntu 22.04 #4630)

@jngrad
CMake: Use modern CMake to handle CUDA
f520206 
Replace the custom CUDA version detection code by CheckLanguage.
Replace the custom CMake option ESPRESSO_WITH_CUDA_COMPILER by
the CUDACXX environment variable.
@jngrad
CMake: Disable Clang-Tidy on FetchContent projects
6470eb7
@jngrad jngrad added the CMake label Dec 28, 2022
@jngrad jngrad marked this pull request as ready for review December 28, 2022 16:17
@jngrad jngrad added this to the Espresso 4.3.0 milestone Dec 28, 2022
@jngrad jngrad requested a review from RudolfWeeber December 30, 2022 23:44
@jngrad jngrad added the automerge Merge with kodiak label Jan 9, 2023
@kodiakhq kodiakhq bot merged commit 30c7c23 into espressomd:python Jan 9, 2023
@jngrad jngrad deleted the cmake-fetchcontent branch January 9, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RudolfWeeber RudolfWeeber RudolfWeeber approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak CMake
Projects
None yet
Milestone
ESPResSo 4.3.0
Development

Successfully merging this pull request may close these issues.

Using GCC and Clang with CUDA 11 on Ubuntu 22.04
2 participants
@jngrad @RudolfWeeber