Improve testing and code coverage #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngrad
force-pushed
the
improve_testing
branch
from
59ed3f3 to
108479e
Compare
Factor out duplicated code, remove unreachable code, add extra checks.
jngrad
force-pushed
the
improve_testing
branch
from
108479e to
4ac0537
Compare
jngrad
commented
Dec 16, 2022
| @@ -382,4 +394,4 @@ def test_zz_pressure_tensor(self): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| ut.main() | |||
| ut.main(verbosity=2) | |||
There was a problem hiding this comment.
The point of this change is to make this test output more information when it times out. The test is flaky and times out at random quite infrequently in CI (not reproducible outside of CI).
reinaual
approved these changes
Dec 23, 2022
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - improve unit testing of core functionality: P3M, MMM1D, OIF, virtual sites, script interface factory - remove unreachable code and factor out code duplication - convert exceptions that are unreachable from the public interface by assertions - improve Sphinx and Doxygen documentation
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - improve unit testing of core functionality: P3M, MMM1D, OIF, virtual sites, script interface factory - remove unreachable code and factor out code duplication - convert exceptions that are unreachable from the public interface by assertions - improve Sphinx and Doxygen documentation
jngrad
added a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - improve unit testing of core functionality: P3M, MMM1D, OIF, virtual sites, script interface factory - remove unreachable code and factor out code duplication - convert exceptions that are unreachable from the public interface by assertions - improve Sphinx and Doxygen documentation
jngrad
pushed a commit
to jngrad/espresso
that referenced
this pull request
Dec 23, 2022
Description of changes: - improve unit testing of core functionality: P3M, MMM1D, OIF, virtual sites, script interface factory - remove unreachable code and factor out code duplication - convert exceptions that are unreachable from the public interface by assertions - improve Sphinx and Doxygen documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: