Script interface maintenance #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collision detection modes are self-contained and cannot be combined.
Add support for dicts with string keys. Improve error messages for failed conversions by get_value() and reduce complexity of demangled symbols by removing allocators from container types.
Rely on the C++ AutoParameters class to remove all the type conversion code from the Cython class. Convert the Cython file to a Python file. Use the standard checkpointing mechanism. Use standard MPI communication instead of MpiCallbacks.
Also make source files self-contained with include-what-you-use.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
pkreissl
previously approved these changes
May 17, 2022
Make C++ exceptions from core classes safe in a MPI-parallel context via a parallel exception handler. When an exception occurs, re-throw the exception on the head node and throw a ScriptInterface::Exception on worker nodes.
reinaual
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
cellsystem.pyxfrom Cython to PythonMpiCallbacksframework in the coredictwith strings as keysGlobalContextframework to make the ScriptInterface object registry resilient to exceptions thrown in MPI-parallel code (implementation of the solution outlined in Script interface object constructors are not thread-safe #4449)