Collision detection maintenance #4484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rely on the C++ AutoParameters class to remove all the type conversion code from the Cython class. Convert the Cython file to a Python file. Use the standard checkpointing mechanism. Setting a protocol with invalid arguments no longer overwrites the global state; the old protocol is automatically restored.
|
Note: this PR is only meant to make the code more maintainable for the 4.2.0 release. It also lays the groundwork for a possible overhaul in a future minor release, e.g. 4.3.0 (#4483). |
|
ping |
reinaual
reviewed
Apr 8, 2022
| auto const param_name = get_value<std::string>(kv.first); | ||
| if (expected_param_names.count(param_name) == 0) { | ||
| // throw if parameter is unknown | ||
| static_cast<void>(get_parameter(param_name)); |
There was a problem hiding this comment.
this is probably violating the SRP...
The uninitialized class member `bool exception_on_collision` could take any value and would randomly trigger a runtime warning or a fatal UBSAN report. The corresponding COLLISION_MODE_EXCEPTION feature was removed in the Tcl version of ESPResSo in 2017.
reinaual
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
collision_detection.pyxto a Python fileAutoParametersclass instanceglue_to_surfaceandbind_at_point_of_collisionrequireVIRTUAL_SITES_RELATIVEcollision_detection.set_params()with invalid arguments no longer leaves the system in an indeterminate state