-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB coupling for RegularDecomposition without ghost shifts. #4470
LB coupling for RegularDecomposition without ghost shifts. #4470
Conversation
3fc9829
to
5a871c7
Compare
f5aac6e
to
12cdd7c
Compare
b59bd6e
to
64d59a7
Compare
@pkreissl, what's the status. Given that this Pr is high-risk and the feature freeze is fast aproaching. |
bf421c7
to
6d65b4e
Compare
6d65b4e
to
813210a
Compare
Resolving the code duplication in the LB coupling of both, regular particles and inertialess tracers, proved to be not quite as straight-forward as anticipated. I am open for suggestions for improvement.
@RudolfWeeber , can you please also have an extra-close look at the coupling logic in the inertialess tracer coupling -- I think I got it right, and the tests pass, but still... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a C++ perspective, this looks good to me. I ran the lb_momentum_conservation.py
test on CPU with particle coupling, kT=0
, 500 time steps, random initial positions and velocities for 20 particles on MPI topologies [1 1 1], [2 1 1], [3 1 1], [2 2 1], [1 2 2], [4 1 1]
. The particle forces at the end of the simulations were identical within 7 decimal places, and were also identical to the same simulation on 1 MPI node with the N-square cell system.
I think @christophlohrmann also wanted to have a look at this PR. What is the status? |
I just also ran the following tests on 1, 2, 3, 4, and 6 cores, respectively, to run them with different MPI topologies:
All these additional test passed. |
Fixes #4466, fixes #4432, closes #4440
Description of changes:
walberla
branch back into thepython
branchlb_particle_coupling.hpp
to get rid of code duplication in (the fixed version of)lb_inertialess_tracers.cpp