MPI-IO maintenance #4455
Merged
MPI-IO maintenance #4455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check multiple uses cases. Write files to a temporary directory to guarantee test files are always cleaned up and that two MPI-IO tests can safely run in parallel. Use a unique prefix derived from the test name to avoid filename collisions (which are fatal errors in MPI-IO). Check the MPI-IO exception mechanism on 1 MPI rank.
Return by value rather than by output argument, use std::string instead of char pointers, remove macro.
Fix incorrect error messages. Improve doxygen blocks and Sphinx docs.
Factor code duplication. Wrap the error message inside the exception.
It is now possible to instantiate multiple Mpiio objects. This is an API breaking change.
Use iterators and STL algorithms. Encapsulate MPI_Exscan logic. Roll out new Particle member accessors. Fix -Wconversion warnings.
reinaual
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
mpiioclass a fully-functionalScriptInterfaceclassmpiiowas removedParticlechanges)