Support recent GCC and Clang compilers #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix shadowed global variables, use STL algorithms, remove superfluous extern declarations, remove unused variables, reduce scope of temporary variables.
Remove unused functions, arguments, struct members, local variables and global variables (fixes all -Wunused-variable warnings and some of the -Wunused-function and -Wunused-parameter warnings).
Macro names with leading underscores are protected.
ESPResSo feature guards only work when config.hpp is included. Rename include guards to avoid leading underscores (triggers the Clang-Tidy bugprone-reserved-identifier warning) and disambiguate header files with similar names.
Make use of Utils::Vector3d::broadcast(), Vector comparison operators and streaming method. Refactor IBM function. Fix some of the -Wunused-parameter warnings and implicit float conversions, including all -bugprone-narrowing-conversions. Fix -modernize-return-braced-init-list and update list of Clang-Tidy rules based on Clang 13.0.0.
jngrad
changed the title
reinaual
previously approved these changes
Jan 24, 2022
| void GetIBMInterpolatedVelocity(const Utils::Vector3d &pos, Utils::Vector3d &v, | ||
| Utils::Vector3d &forceAdded) { | ||
| template <bool ReturnVelocity> | ||
| Utils::Vector3d GetIBMInterpolatedVelocity(Utils::Vector3d const &pos) { |
There was a problem hiding this comment.
It is out of the scope for this PR but this function clearly is in a really bad state...
Factor out code duplication, convert unreachable throw statements to assertions and reduce branching in LB, ELC, MDLC, P3M and DP3M code. Add test cases for actor exceptions.
reinaual
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
-Wmissing-brace,-Wunused-variable,-bugprone-narrowing-conversions,bugprone-reserved-identifier,-modernize-return-braced-init-list-Wunused-variable)es_math.pyin the test suite (was never executed in CI)