Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cluster analysis folding code #4363

Merged
merged 4 commits into from
Oct 25, 2021
Merged

Fix cluster analysis folding code #4363

merged 4 commits into from
Oct 25, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Sep 28, 2021

Fixes #4362

Description of changes:

  • properly fold cluster coordinates
  • test cluster analysis edge cases

@jngrad jngrad requested a review from RudolfWeeber October 21, 2021 18:48
@jngrad jngrad added this to the Espresso 4.2 milestone Oct 25, 2021
@jngrad jngrad added the automerge Merge with kodiak label Oct 25, 2021
@kodiakhq kodiakhq bot merged commit ea4f638 into espressomd:python Oct 25, 2021
@jngrad jngrad deleted the cluster_analysis_folding branch October 25, 2021 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RudolfWeeber RudolfWeeber RudolfWeeber approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core Testcase
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

Incorrect coordinates folding in cluster analysis module
2 participants
@jngrad @RudolfWeeber