Remove Wang-Landau Reaction Ensemble algorithm #4288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Wang-Landau Reaction Ensemble (WLRE) implementation is tightly coupled to the other reaction methods in the C++ core. This accidental complexity slows down the development and improvement of the other reaction methods. Rewriting the WLRE method to improve modularity would be a significant project for the core team. This reaction method is not actively used by the community, and a recent call on the ESPResSo mailing list did not receive any response against the removal of the method:
https://lists.nongnu.org/archive/html/espressomd-users/2021-06/msg00001.html
Partial fix for #4251 (removing WLRE hooks)
Closes #4156
Description of changes:
ReactionAlgorithm
(memberparticle_inside_exclusion_radius_touched
was uninitialized).