IBM volume conservation maintenance #4286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation had undefined behavior for softID >= IBM_MAX_NUM. The IBM_MAX_NUM macro was removed and replaced by dynamic memory management.
reinaual
previously approved these changes
Jun 24, 2021
reinaual
previously approved these changes
Jun 24, 2021
Make sure volume conservation relaxes the mesh volume towards the reference volume. Add a callback to query the current volume.
reinaual
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4284
Description of changes:
std::vectorfor memory managementIBM_MAX_NUMmacro, now that anysoftIDis valid