Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observables sanity checks #4255

Merged
merged 7 commits into from
May 25, 2021
Merged

Observables sanity checks #4255

merged 7 commits into from
May 25, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented May 21, 2021

Fixes #4212

Description of changes:

  • catch memory errors when passing an invalid observable to the correlator framework
  • raise python exceptions when instantiating observables with invalid parameters

@jngrad jngrad added this to the Espresso 4.2 milestone May 21, 2021
@jngrad jngrad requested a review from reinaual May 21, 2021 11:42
@jngrad jngrad added the automerge Merge with kodiak label May 25, 2021
@kodiakhq kodiakhq bot merged commit ecdb57f into espressomd:python May 25, 2021
@jngrad jngrad deleted the observables-sanity-checks branch May 25, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
automerge Merge with kodiak BugFix Core
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

RDF Observable parameters are not checked
2 participants
@jngrad @reinaual