Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ElectrokineticsRoutines inherit from LBFluidRoutines #4228

Merged
merged 2 commits into from
Apr 14, 2021
Merged

make ElectrokineticsRoutines inherit from LBFluidRoutines #4228

merged 2 commits into from
Apr 14, 2021

Conversation

christophlohrmann
Copy link
Contributor

@christophlohrmann christophlohrmann commented Apr 14, 2021 •
edited by jngrad
Loading

Description of changes:

  • ElectrokineticsRoutines so far was an incomplete copy of LBFluidRoutines with one extra property
  • removed unneeded ekin code that reads quantities from GPU LB
  • interface change: EK does not have .pressure anymore, instead .pressure_tensor, which is what it actually returns
  • bugfix: EK node access no longer accepts node indices as floating point values

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jngrad jngrad self-requested a review April 14, 2021 14:50
jngrad
jngrad approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@jngrad jngrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jngrad jngrad added this to the Espresso 4.2 milestone Apr 14, 2021
@kodiakhq kodiakhq bot merged commit 547f708 into espressomd:python Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jngrad jngrad jngrad approved these changes

Assignees
No one assigned
Labels
ApiChange automerge Merge with kodiak BugFix Python
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@christophlohrmann @jngrad