Refactor cylindrical coordinates transformation and dependent observables #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
christophlohrmann
previously approved these changes
Mar 10, 2021
|
A very good PR. Naming is spot on! |
- Refactor coordinate transformation code and add orientation for cylindrical coordinate system transformations. - Update dependent core objects using the cylinder coordinate transformation. Co-authored-by: Christoph Lohrmann <[email protected]> Co-authored-by: Kai Szuttor <[email protected]>
jngrad
changed the title
jngrad
approved these changes
Mar 10, 2021
|
Thanks alot! I guess this turned out a bigger project than initially planned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4023, fixes #4067, closes #4114
Description of changes:
orientationtoHollowConicalFrustum