Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ELC an actor #4125

Merged
merged 8 commits into from
Mar 3, 2021
Merged

Make ELC an actor #4125

merged 8 commits into from
Mar 3, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Mar 1, 2021

Fixes #2155

Description of changes:

  • ELC is now an actor that takes a P3M actor as argument
  • the ELC actor can now be removed from the list of actors
  • test checkpointing of P3M-based methods

jngrad added 5 commits March 1, 2021 15:06
@jngrad
core: Remove P3M member additional_mesh
8dd2a64 
This member is a duplicate of the ELC member space_layer.
@jngrad
python: Make ELC an actor via composition
0e527ce
@jngrad
tests: Add DP3M/ELC/Scafacos checkpointing checks
7ba3b13
@jngrad
tests: Check ELC exception mechanism
944b9a7
@jngrad
python: Improve ELC and MDLC docstrings
bf25f94 
Both methods check for the presence of particles in the gap region.
Show variable names that failed validation.
@jngrad jngrad added this to the Espresso 4.2 milestone Mar 1, 2021
@jngrad jngrad requested a review from reinaual March 1, 2021 16:27
reinaual
reinaual previously approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@reinaual reinaual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/python/espressomd/magnetostatic_extensions.pyx Outdated Show resolved Hide resolved
@jngrad @reinaual
docs: Apply suggested changes
b2dcdce 
Co-authored-by: Alexander Reinauer <[email protected]>
@jngrad jngrad added the automerge Merge with kodiak label Mar 3, 2021
@kodiakhq kodiakhq bot merged commit eb3604b into espressomd:python Mar 3, 2021
@jngrad jngrad deleted the elc-actor branch March 3, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reinaual reinaual reinaual approved these changes

Assignees
No one assigned
Labels
ApiChange automerge Merge with kodiak Core Documentation Python Testcase
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.

ELC misclassified as electrostatic extension
2 participants
@jngrad @reinaual