Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script interface maintenance #4121

Merged
merged 15 commits into from
Mar 1, 2021
Merged

Script interface maintenance #4121

merged 15 commits into from
Mar 1, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Feb 24, 2021 •
edited
Loading

Description of changes:

  • fix regressions introduced in the last script interface refactor
  • add python dict to the list of types allowed in the script interface (gets converted to std::unordered_map<int, Variant>)
  • make coupling-based fields throw an error when calling a coupling parameter setter, instead of silently ignoring the new value (the coupling object is const), and take a dict instead of having the user manually cast dict_items to list (API change)
  • improve testing of field-based constraints and shapes

@jngrad
tests: Fix broken testcase
e59d91c
@jngrad
python: Fix error message
1e873d6
@jngrad
python: Disable conversion of dict to Variant
6750731 
Iterating a dict generates a list of keys, so it is converted to
std::vector<Variant> instead of std::unordered_map<Variant,Variant>.
@jngrad
script_interface: Fix broken particle_scales feature
a7e0d1e 
Fixes regressions from 7414db9:
typo in member name and incorrect serialization.
@jngrad
tests: Improve testing of fields
04ad5dd
@jngrad
python: Make coupling parameters read-only
20d877c 
A coupling object is created from the parameters during construction
of a field object. Changing the coupling parameters later doesn't
update the coupling object.
@jngrad
tests: Improve testing of Union and Ellipsoid
4f14b6f
KaiSzuttor
KaiSzuttor reviewed Feb 24, 2021
View reviewed changes
src/script_interface/get_value.hpp Outdated Show resolved Hide resolved
src/script_interface/get_value.hpp Outdated Show resolved Hide resolved
@jngrad jngrad added this to the Espresso 4.2 milestone Feb 25, 2021
@jngrad jngrad requested a review from KaiSzuttor February 26, 2021 14:21
@jngrad jngrad mentioned this pull request Feb 26, 2021
Closed
KaiSzuttor
KaiSzuttor reviewed Mar 1, 2021
View reviewed changes
src/shapes/unit_tests/NoWhere_test.cpp Outdated Show resolved Hide resolved
src/shapes/unit_tests/NoWhere_test.cpp Outdated Show resolved Hide resolved
@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Mar 1, 2021
@kodiakhq kodiakhq bot merged commit 17b310e into espressomd:python Mar 1, 2021
@jngrad jngrad deleted the script_interface_maintenance branch March 1, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees
No one assigned
Labels
ApiChange automerge Merge with kodiak BugFix ScriptInterface Testcase
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @KaiSzuttor