Refactor P3M/DP3M exception mechanism #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert comments to doxygen comments. Remove documentation of DP3M variables and macros that no longer exist.
The alpha parameter cannot be constrained to a specific value. It is always derived from the other parameters during tuning.
Invalid P3M/DP3M parameters now throw exceptions. In the previous implementation, the returned error code was silently ignored, and a std::runtime_error thrown by P3MGPU wasn't caught in MPI callbacks. Code duplication between the core and python interface of P3M/DP3M was removed.
reinaual
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4117
Description of changes:
RuntimeErrorwhen a P3M/DP3M actor is instantiated with incorrect parameters, instead of silently ignoring the error code from the core and leaving the core struct in an undefined state (e.g. an incorrectalphawould cause the core setter to return early with an unhandled error code, leavingalphaandaccuracyuninitialized in the core)alphaduring tuning (had no effect:alphais derived from the other parameters)