Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove manual memory management in LB code #4108

Merged
merged 17 commits into from
Jan 29, 2021
Merged

Remove manual memory management in LB code #4108

merged 17 commits into from
Jan 29, 2021

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Jan 27, 2021

Description of changes:

  • remove unused Utils::Mpi::all_gatherv() and Utils::realloc()
  • reduce usage of Utils::malloc() (partial fix for Remove remaining manual memory management #2900)
  • improve readability of the LB halo code
  • fix memory leak in LB halo constructors

@jngrad jngrad added this to the Espresso 4.2 milestone Jan 27, 2021
@jngrad jngrad marked this pull request as ready for review January 27, 2021 16:05
@jngrad jngrad requested a review from KaiSzuttor January 27, 2021 16:05
KaiSzuttor
KaiSzuttor reviewed Jan 28, 2021
View reviewed changes
src/core/grid_based_algorithms/halo.hpp Outdated Show resolved Hide resolved
src/core/grid_based_algorithms/halo.hpp Outdated Show resolved Hide resolved
src/core/grid_based_algorithms/lbgpu_cuda.cu Outdated Show resolved Hide resolved
src/core/grid_based_algorithms/halo.hpp Outdated Show resolved Hide resolved
KaiSzuttor
KaiSzuttor previously approved these changes Jan 29, 2021
View reviewed changes
@KaiSzuttor
Copy link
Member

thanks!

@jngrad jngrad self-assigned this Jan 29, 2021
@KaiSzuttor KaiSzuttor added the automerge Merge with kodiak label Jan 29, 2021
@kodiakhq kodiakhq bot merged commit 9d103a2 into espressomd:python Jan 29, 2021
@jngrad jngrad deleted the remove_manual_memory_lb branch January 29, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaiSzuttor KaiSzuttor KaiSzuttor approved these changes

Assignees

@jngrad jngrad

Labels
automerge Merge with kodiak CodeQuality Core
Projects
None yet
Milestone
Espresso 4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jngrad @KaiSzuttor